Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package:messages_builder #721

Merged
merged 47 commits into from
Sep 21, 2023
Merged

Add package:messages_builder #721

merged 47 commits into from
Sep 21, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Sep 12, 2023

Add the code to generate the messages files, together with an example in the package:messages directory.

At the moment, the builder takes more options than we would probably want (some have been pushed to future PRs for easier review). For the stable version of this package, the plan is to cut back on these to reduce future maintenance burden.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 12, 2023
@mosuem mosuem changed the base branch from main to addMessagesWeb September 12, 2023 14:20
@github-actions
Copy link

github-actions bot commented Sep 12, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:intl4x 0.7.0 already published at pub.dev
package:intl_translation 0.19.0-dev pre-release version (no publish necessary)
package:intl 0.19.0-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ❗

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/messages/example_json/lib/testarbctx2.g.dart
pkgs/messages/example_json/lib/testarb.g.dart

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/intl_translation/test/generate_localized/code_map_messages_all_locales.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_fr.dart
pkgs/intl_translation/test/two_components/component_messages_fr_xyz123.dart
pkgs/intl_translation/test/two_components/component_messages_all.dart
pkgs/intl_translation/test/two_components/app_messages_fr.dart
pkgs/intl_translation/test/two_components/app_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_all_locales.dart
pkgs/intl_translation/test/two_components/app_messages_all_locales.dart
pkgs/intl_translation/example/lib/generated/messages_es.dart
pkgs/intl_translation/example/lib/generated/messages_all_locales.dart
pkgs/intl_translation/example/lib/generated/messages_de.dart
pkgs/intl_translation/example/lib/generated/messages_iw.dart
pkgs/intl_translation/example/lib/generated/messages_all.dart
pkgs/intl_translation/example/lib/generated/messages_de_CH.dart
pkgs/intl_translation/example/lib/generated/messages_en.dart

This check can be disabled by tagging the PR with skip-license-check

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

@github-actions github-actions bot added package:messages and removed type-infra A repository infrastructure change or enhancement labels Sep 12, 2023
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 12, 2023
@mosuem mosuem removed the type-infra A repository infrastructure change or enhancement label Sep 12, 2023
@mosuem mosuem changed the base branch from addMessagesWeb to main September 12, 2023 15:09
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 12, 2023
@mosuem mosuem changed the base branch from main to addMessagesWeb September 12, 2023 15:25
Base automatically changed from addMessagesWeb to main September 15, 2023 11:48
@mosuem mosuem merged commit 2dc1d58 into main Sep 21, 2023
9 checks passed
@mosuem mosuem deleted the addMessagesBuilder branch September 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:messages type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants